Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix(ci): add missing dependency-review job to CI workflow#53

Merged
roottool merged 4 commits intomainfrom
fix/ci-add-dependency-review-job
Feb 15, 2026
Merged

fix(ci): add missing dependency-review job to CI workflow#53
roottool merged 4 commits intomainfrom
fix/ci-add-dependency-review-job

Conversation

@roottool
Copy link
Copy Markdown
Owner

Description

The wc-dependency-review.yml reusable workflow was defined but never invoked from ci.yml, causing dependency review to be silently skipped on pull requests.

Type of Change

  • Tooling / CI (changes to build tools, CI configuration)

Boundary Checklist (Required for Implementation Changes)

  • This is a non-implementation change (Documentation, Tooling, or CI only)
    • Reason: CI workflow configuration only — no changes to library source code

Security & API Stability

Security Impact:

  • No impact on security (no changes to forbidden keys, prototype safety)

API Contract:

  • No changes to public API (parse function signature, type definitions)

Versioning:

  • Change is compatible with current v0.x versioning policy

Testing

Automated Checks:

  • TypeScript type checking passes (bun run check:type:source)
  • All tests pass (bun run test)
  • Build succeeds (bun run build)

Additional Verification:

  • Verified that wc-dependency-review.yml is a valid reusable workflow (on: workflow_call)
  • Confirmed the setup.outputs.dependencies path filter output was already defined but unused
  • Added github.event_name == 'pull_request' guard because actions/dependency-review-action requires PR context
  • Added dependency-review to status-check needs to catch failures

Changes

  • Add dependency-review job to ci.yml that calls wc-dependency-review.yml
    • Runs only when bun.lock changes (needs.setup.outputs.dependencies == 'true')
    • Runs only on pull_request events (required by actions/dependency-review-action)
  • Add dependency-review to status-check job's needs list

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

The wc-dependency-review.yml reusable workflow was defined but never
invoked from ci.yml, causing dependency review to be silently skipped.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@roottool roottool self-assigned this Feb 15, 2026
…review

Remove comment-summary-in-pr feature and the pull-requests: write
permission it required. The dependency-review-action only needs
contents: read without the comment feature.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a393f5f) to head (eecd157).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           22        22           
  Branches         6         6           
=========================================
  Hits            22        22           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roottool roottool merged commit 76042ae into main Feb 15, 2026
12 checks passed
@roottool roottool deleted the fix/ci-add-dependency-review-job branch February 15, 2026 07:23
@roottool roottool added the ci Some changes have been changed to CI. label Mar 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci Some changes have been changed to CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant